This repository has been archived by the owner on Aug 6, 2022. It is now read-only.
Refactoring #2
Open
Refactoring #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fherrera124
reviewed
Dec 30, 2020
|
Ah ok, I did expect something like that, esp. as I wasn't really sure what that part of code was doing... I'll revert that part. |
|
@zserik I added your commits to my fork and made some changes and added support to retrieve the covers, can you review it? If it's worth it, you can add some changes to this PR. |
shuffle some stmts around move utility fns to the bottom refac: move fname calculation into 'write_to_disk' reorder code to improve clarity get rid of duplicated file existence check print invalid spotify types handle_entry: get rid of unused generic lifetime params cache Show and Album.name
|
I condensed the code into 3 commits, which should still capture most of the intent behind the changes. (I especially wanted to get rid of some back-and-forth stuff and couldn't move all commits into place without introducing conflicts while rebasing, so I squashed the long run). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twitter.com/1kescher/status/1343964329952108546
unspaghetti'ed
actually, this PR modifies the code behavoir a bit, e.g. if a song isn't downloaded, because the destination file already exists, some debug output is skipped (e.g. moved after the condition), as this allows more efficient processing (but only works if the info wouldn't be interesting, anyways).
It is probably a good idea to squash this before merging (I think GitHub has this as an option).