Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce infix-crypto-types #935

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Introduce infix-crypto-types #935

merged 1 commit into from
Feb 8, 2025

Conversation

mattiaswal
Copy link
Contributor

To only show supported types, simpler when autogenerate web/cli.

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal requested a review from troglobit February 8, 2025 10:18
@mattiaswal mattiaswal force-pushed the infix-crypto-types branch 2 times, most recently from 900b5d3 to e038114 Compare February 8, 2025 11:44
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only an ordering bug in the ChangeLog:

  • "YANG type has changed for SSH private/public keys .." vs
  • "YANG type for SSH private/public keys has changed .."

@mattiaswal
Copy link
Contributor Author

lgtm, only an ordering bug in the ChangeLog:

  • "YANG type has changed for SSH private/public keys .." vs
  • "YANG type for SSH private/public keys has changed .."

I suck on writing, really should run all text through a AI...

To only show supported types, simpler when autogenerate web/cli.
@mattiaswal mattiaswal merged commit 343c465 into main Feb 8, 2025
4 of 6 checks passed
@mattiaswal mattiaswal deleted the infix-crypto-types branch February 8, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants