Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple VXLAN support #888

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Add simple VXLAN support #888

merged 4 commits into from
Jan 15, 2025

Conversation

mattiaswal
Copy link
Contributor

Description

This is a very simple implementation. Only support simple point-to-point tunnels right now, but is easy extendable for more use cases.

Also allow to add the parameters to a test, as {parameter} in the description and test steps, this will be replaced
with the parameter value.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

troglobit and others added 4 commits January 13, 2025 20:16
…ription

This is only availible for tests that require paramters. If the test have a
parameter --data the description and test steps can contain {data} which will
be replaced with tha actual data of the parameter data in the test specification.
This is just a first step to add VXLAN tunnels, much more remains.
Implemented right now is as GRE, local, remote and a VNI.

Also refactor gre_basic and gre_bridged to generic tunnel tests,
the same test now tests VXLAN as well.
@mattiaswal mattiaswal requested review from troglobit and wkz January 14, 2025 14:16
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc is a bit on the thin side 😄, but the implementation looks great! Nice to see that much of the tests can be shared with GRE 😍

@wkz wkz merged commit 94cd526 into main Jan 15, 2025
6 checks passed
@wkz wkz deleted the vxlan branch January 15, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants