Update upgrade test #846
Merged
Update upgrade test #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
fix-upgrade-test
branch
from
d31be19 to
3f6fbd4
Compare
mattiaswal
force-pushed
the
fix-upgrade-test
branch
4 times, most recently
from
13c34cf to
ac86a74
Compare
mattiaswal
force-pushed
the
fix-upgrade-test
branch
from
ac86a74 to
d81a2c2
Compare
wkz
requested changes
Dec 4, 2024
|
|
||
| with test.step("Verify the boot order is the orignal configured"): | ||
| # Wait for sshd to start. | ||
| until(lambda: old_bootorder == bootloader.get_boot_order(), attempts=200) |
There was a problem hiding this comment.
Suggested change
| until(lambda: old_bootorder == bootloader.get_boot_order(), attempts=200) | |
| order = bootloader.get_boot_order() | |
| assert order == old_bootorder, f"Unexpected bootorder: {repr(order)}" |
until seems counter intuitive here, since the boot order is not a volatile thing. Do we need more assurances from the SSH connection? Should we add a long -oConnectTimeout 300 or something?
Also, if this ever happens, I think we want to know which state we're leaving the system in
|
|
||
| def set_boot_order(self, order): | ||
| return self.ssh.run(f"sudo grub-editenv /mnt/aux/grub/grubenv set ORDER='{order}'".split()).returncode | ||
|
|
||
| with infamy.Test() as test: |
There was a problem hiding this comment.
We might want to add some way for a test implementation to register cleanup functions. Such that the boot order is restored even if we break the test in the middle (e.g., pressing C-c)
mattiaswal
force-pushed
the
fix-upgrade-test
branch
2 times, most recently
from
8c66b8c to
85a3d5d
Compare
mattiaswal
force-pushed
the
fix-upgrade-test
branch
6 times, most recently
from
e32ba34 to
47c5492
Compare
|
Nice work, only some squash and rebase left to do! 😎 👍 |
Works on both virtual and physical target
mattiaswal
force-pushed
the
fix-upgrade-test
branch
from
2bfe606 to
f023304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: