Add ssh config #838
Open
Add ssh config #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
add-ssh-config
branch
4 times, most recently
from
166d5df to
570a89b
Compare
mattiaswal
force-pushed
the
add-ssh-config
branch
2 times, most recently
from
13eb6db to
c511ea6
Compare
module: infix-services
+--rw mdns
| +--rw enabled? boolean
+--rw ssh
| +--rw enabled? boolean
| +--rw hostkey* ks:asymmetric-key-ref
| +--rw listen* [name]
| +--rw name string
| +--rw address? inet:ip-address
| +--rw port? inet:port-number
+--rw web
+--rw enabled? boolean
+--rw console
| +--rw enabled? boolean
+--rw netbrowse
| +--rw enabled? boolean
+--rw restconf
+--rw enabled? boolean
|
mattiaswal
force-pushed
the
add-ssh-config
branch
2 times, most recently
from
6289fef to
b558ece
Compare
troglobit
requested changes
Dec 3, 2024
mattiaswal
force-pushed
the
add-ssh-config
branch
4 times, most recently
from
6b8d07d to
0cfff78
Compare
mattiaswal
force-pushed
the
add-ssh-config
branch
2 times, most recently
from
7d1b80f to
95dcb26
Compare
troglobit
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Nice work, only minor stuff to comment on.
I guess the implement commit should be squashed with the last commit that adds rmrf(), or split and squashed where one part is squashed with Add support for configurable SSH server?
troglobit
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Awesome, getting there! A few comments, and some still outstanding, added/updated.
Also, as per our discord discussion. It would be great to at least get an example of how-to-add-ssh to my custom factory-config, here https://github.com/kernelkit/infix/blob/main/doc/branding.md#example-snippets
package/skeleton-init-finit/skeleton/etc/finit.d/available/sshd.conf
Outdated
Show resolved
Hide resolved
src/confd/yang/infix-services.yang
Outdated
| import ietf-crypto-types { | ||
| prefix ct; | ||
| reference | ||
| "RFC AAAA: YANG Data Types and Groupings for Cryptography"; |
There was a problem hiding this comment.
RFC 9640 or pre-RFC draft?
mattiaswal
force-pushed
the
add-ssh-config
branch
2 times, most recently
from
a171837 to
b8768d5
Compare
for recursive delete of directories
This also makes it possible to remove the key 'genkey' if the user wants.
This since there is breaking changes.
mattiaswal
force-pushed
the
add-ssh-config
branch
from
b8768d5 to
9e8e5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix #441
But implemented in infix-services instead (without ietf-ssh)
Checklist
Tick relevant boxes, this PR is-a or has-a: