Expand mDNS settings #833
Merged
Expand mDNS settings #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
force-pushed
the
mdns-settings
branch
from
72c2d49 to
eaaf893
Compare
Closed
troglobit
force-pushed
the
mdns-settings
branch
from
eaaf893 to
6a460c3
Compare
|
@mattiaswal + @jovatn this PR is now finished and awaiting your review. |
jovatn
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Update https://github.com/kernelkit/infix/blob/main/doc/discovery.md#mdns with (rudimentary) descriptions of available mdns settings.
sysctl updates looks good to me, but perhaps we could have an IRL session for rubber ducking on sysctl changes?
Signed-off-by: Joachim Wiberg <[email protected]>
These changes are based on the sysctl recommendations by Frr [1]. Not all recommendations have been incorporated, e.g., ip forwarding is not enabled per interface, because in Infix this is an opt-in feature. A readme.txt has been added, documenting the various settings. New for IPv4: - Adjust IGMP max memberships: 20 -> 1000 - Use neighbor information on nexthop selection - Use inbound interface address on ICMP errors - Ignore routes with link down - Disable rp_filter ARP settings have been changed to better fit routers, i.e., systems with multiple interfaces: - Always use best local address when sending ARP - Only reply to ARP if target IP is on the inbound interface - Generate ARP requests when device is brought up or HW address changes New for IPv6: - Keep static global addresses on link down - Ignore routes with link down Fixes #829 [1]: https://github.com/FRRouting/frr/blob/master/doc/user/Useful_Sysctl_Settings.md Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
force-pushed
the
mdns-settings
branch
2 times, most recently
from
fef6de8 to
4d26e39
Compare
mattiaswal
requested changes
Dec 4, 2024
Use container for interface allow/deny and for reflector settings. Hopefully there will be more settings in the future, e.g., control reflector interfaces independently. Fix #678 Signed-off-by: Joachim Wiberg <[email protected]>
The Avahi daemon needs to be restarted when changing its configuration file in /etc/avahi/avahi-daemon.conf, not sufficient to SIGHUP. Also, minor reformatting for new style. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Fixes the following issue when deleting /infix-services:mdns/interfaces,
which works fine over RESTCONF:
Traceback (most recent call last):
File "/home/jocke/src/infix/test/./case/infix_services/mdns_allow_deny/test.py", line 142, in <module>
dut.delete_xpath("/infix-services:mdns/interfaces")
File "/home/jocke/src/infix/test/infamy/netconf.py", line 418, in delete_xpath
oldd = mod.parse_data_dict(old, no_state=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/.infix/venv/lib/python3.11/site-packages/libyang/schema.py", line 215, in parse_data_dict
return dict_to_dnode(
^^^^^^^^^^^^^^
File "/root/.infix/venv/lib/python3.11/site-packages/libyang/data.py", line 1277, in dict_to_dnode
result.root().validate(
File "/root/.infix/venv/lib/python3.11/site-packages/libyang/data.py", line 430, in validate
self.validate_all(no_state, validate_present)
File "/root/.infix/venv/lib/python3.11/site-packages/libyang/data.py", line 449, in validate_all
raise self.context.error("validation failed")
libyang.util.LibyangError: validation failed:
Invalid leafref value "e3" - no target instance "/if:interfaces/if:interface/if:name" with the same value.
The patch skips validation of the diff in favor of checking the result
of libyang.xpath_del().
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Overhaul text and grammar. Simplify, correct, and add information about the new mDNS settings. Replace 'unit' with 'device', which is the more common term for hardware. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
force-pushed
the
mdns-settings
branch
from
4d26e39 to
1895e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for modifying the following Avahi daemon settings:
domain-nameallow-interfacesdeny-interfacesenable-reflectorreflect-filtersAlso included, a review of the default
sysctlsettings, and some fixes and clarifications to the Networking Guide.Checklist
Tick relevant boxes, this PR is-a or has-a: