Verify that bridge vlan separation works properly for broadcast packets #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should include a fixes line to close #773 Other than that it looks good to me. But I'll leave the full review to @mattiaswal 👍 |
axkar
force-pushed
the
update-br-vlan-sep
branch
from
311962d to
516e024
Compare
- Verify that broadcast packets are also properly moved accross the bridge, i.e. the broadcast packets sent from vlan interface VLAN10 do not reach VLAN20 Fixes #773
axkar
force-pushed
the
update-br-vlan-sep
branch
from
516e024 to
798194b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Tick relevant boxes, this PR is-a or has-a: