Add CLI interface statistics #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should make reading easer and make it more obvious if an interface doesn't have an IP set. Signed-off-by: Richard Alpe <[email protected]>
Print in and out octets for each interface that has the information in the operational data store. Signed-off-by: Richard Alpe <[email protected]>
This allows us to show empty values easier, while not affecting the if statements. This allows for a greater flexibility in which values are shown and not. For example, we want to show empty columns for data that the user adds/removes, such as IP addresses. ... ipv4 addresses : ... However, we don't want to show empty columns for information that should never exist for a particular interface type. Signed-off-by: Richard Alpe <[email protected]>
troglobit
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add statistics to the detailed show interface view.
Also, print empty columns for some values that the user adds/remove, such as ipv4 address.
This make it easier to spot if a interface has no ip set.