Rewrite CLI pretty priter in Python #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bridge master into "infix-interfaces:bridge-port" -> "bridge". Signed-off-by: Richard Alpe <[email protected]>
Add ietf-if-extensions:parent-interface which is synonymous with link in ip-route. Signed-off-by: Richard Alpe <[email protected]>
Signed-off-by: Richard Alpe <[email protected]>
This test is a "unit" test, which implies that it can be executed locally without access to a Infix target environment. Signed-off-by: Richard Alpe <[email protected]>
The old version (bash) where slow and cluttered. This version is much faster and easier to read / maintain. Signed-off-by: Richard Alpe <[email protected]>
|
Minor, missing Not needed in _classic builds or minimal. The minimal defconfig is deprecated and will be dropped the coming week. |
Signed-off-by: Richard Alpe <[email protected]>
troglobit
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation in bash is slow and cluttered. This PR rewrites the pretty printer in Python3. It also adds python3 to target and adds additional operational data to the datastore (see commits).
This PR changes the output format for
show interfacesa bit, mainly based on the outcome of the discussions in #104 .