Merge pull request #10 from kentlouisetonino/feat/cleanup-files

feat: Clean Up
kentlouisetonino · May 8, 2024 · 7c6845b · 7c6845b
2 parents e879f07 + f8fc812
commit 7c6845b
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 8 deletions.
diff --git a/src/services/binary/get_binary_input.go b/src/services/binary/get_binary_input.go
@@ -8,7 +8,6 @@ import (
  "github.com/kentlouisetonino/baseshift/src/helpers"
 )
 
-// This handles the binary input value and its validation.
 func getBinaryInput() int64 {
  var option int64
  var optionChecker string

diff --git a/src/services/binary/get_binary_to_decimal.go b/src/services/binary/get_binary_to_decimal.go
@@ -2,7 +2,6 @@ package binary
 
 import "math"
 
-// Converts binary number to decimal.
 func getBinaryToDecimal(binary int64) int64 {
  binaryToArray := getReversedBinaryArray(binary)
  decimal := int64(0)

diff --git a/src/services/binary/get_reverse_int_array.go b/src/services/binary/get_reverse_int_array.go
@@ -1,6 +1,5 @@
 package binary
 
-// Reversed the array of int64.
 func getReverseIntArray(array []int64) []int64 {
  lastIndex := len(array) - 1
  reversedArray := []int64{}

diff --git a/src/services/binary/get_reversed_binary_array.go b/src/services/binary/get_reversed_binary_array.go
@@ -1,6 +1,5 @@
 package binary
 
-// Reversed the binary and return an array of binary.
 func getReversedBinaryArray(binary int64) []int64 {
  var arrayOfBinary []int64
 

diff --git a/src/services/decimal/get_decimal_input.go b/src/services/decimal/get_decimal_input.go
@@ -7,7 +7,6 @@ import (
  "github.com/kentlouisetonino/baseshift/src/helpers"
 )
 
-// This handles the decimal input value and its validation.
 func getDecimalInput() int64 {
 
  // Declare the variables.

diff --git a/src/services/decimal/get_decimal_to_binary.go b/src/services/decimal/get_decimal_to_binary.go
@@ -5,7 +5,6 @@ import (
  "strings"
 )
 
-// Converts binary number to decimal.
 func getDecimalToBinary(decimal int64) int64 {
  binaryStringArray := []string{}
 

diff --git a/src/services/hexadecimal/get_hexadecimal_input.go b/src/services/hexadecimal/get_hexadecimal_input.go
@@ -10,7 +10,6 @@ import (
 
 func getHexadecimalInput() string {
  var optionChecker string
- validOptions := []string{"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "A", "B", "C", "D", "E", "F"}
 
  // Ask the octal input from the end user.
  fmt.Print(helpers.ThreeSpace, "Hexadecimal", helpers.ThreeSpace, ": ")
@@ -21,7 +20,7 @@ func getHexadecimalInput() string {
  // Check if hexadecimal input is valid.
  hexadecimalArray := strings.SplitAfter(optionChecker, "")
  for i := 0; i < len(hexadecimalArray); i++ {
- if slices.Contains(validOptions, hexadecimalArray[i]) == false {
+ if slices.Contains(hexValidOptions, hexadecimalArray[i]) == false {
  return "-1"
  }
  }

diff --git a/src/services/hexadecimal/types.go b/src/services/hexadecimal/types.go
@@ -37,3 +37,5 @@ var hexToBinaryArrayMap = map[string][]int{
  "E": {1, 1, 1, 0},
  "F": {1, 1, 1, 1},
 }
+
+var hexValidOptions = []string{"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "A", "B", "C", "D", "E", "F"}