Skip to content

Add optional -json for STDOUT JSON string #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Nineapsofttech
Copy link

Add optional -json for STDOUT JSON string.
STDOUT Object of

  • success array - array of success urls.
  • error array - array of fail to load urls.

@kendallb
Copy link
Owner

I like this change, but please move QString dataPath = QApplication::applicationDirPath() back to it's original location below it's comment (much better to define stuff where it is needed, with related comments).

Also please fix all the formatting where the formatting has been compressed as that is now how the code is formatted in this project. So this:

if(this->json){

needs to be come this:

if (this->json) {

Quite a lot of code got reformatted so that all needs to be cleaned up.

@kendallb
Copy link
Owner

This code tree no longer merges clean, due to other changes in master. Can you resolve the conflicts so I can bring it in?

Also last time we tried Qt5 we ended up with problems (don't recall exactly what they were), but we went back to Qt 4.8 to resolve that. Is Qt5 working OK for you?

@kendallb
Copy link
Owner

I still have conflicts and can't merge this in clean. Can you resolve them in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants