Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add battery_percentage property to --bluetoothctl output #564

Merged

Conversation

nmattela
Copy link
Contributor

This pull request adds battery_percentage to the output of jc --bluetoothctl. Bluetooth devices with a battery can communicate their battery percentage through the Battery Percentage metric that is received from bluetoothctl info. It takes the form of 0xn (N) where n is the battery percentage in hexadecimal and N is the battery percentage in decimal. I basically extract the decimal format from the bluetoothctl info output and add it to the output generated by jc.

@nmattela nmattela changed the title feat: Adds battery_percentage property to --bluetoothctl output feat: Add battery_percentage property to --bluetoothctl output Apr 24, 2024
@kellyjonbrazil kellyjonbrazil changed the base branch from master to dev April 24, 2024 18:52
@kellyjonbrazil
Copy link
Owner

Thank you for the contribution! I'll take a look and merge in when I start working on the next release. Tests are failing, but I don't think that's your fault. Looks like something changed in the github actions. I'll have to investigate.

Thanks again!

@kellyjonbrazil
Copy link
Owner

Cool, tests are passing now. I'll merge this when I start working on the next release. Thanks!

@kellyjonbrazil kellyjonbrazil merged commit 4ef34f7 into kellyjonbrazil:dev Apr 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants