feat!: replace tinyglobby with built-in fs.glob - #411
Open
hyperz111 wants to merge 2 commits into
Open
Conversation
keithamus
reviewed
Apr 28, 2026
Comment on lines
+74
to
+77
| const files = | ||
| process.platform === 'win32' | ||
| ? results.map((result) => result.replaceAll('\\', '/')) | ||
| : results |
Owner
There was a problem hiding this comment.
This doesn't look right. This should use path.normalize or so, right?
Contributor
Author
There was a problem hiding this comment.
I think this is good, because glob will return array of paths using OS-spesific slash and path.normalize doesn't work. I replace slash for keep consistent with snapshots.
fisker
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will replace
tinyglobbywith built-infs.glob, but we need to only support Node.js22.17or higher.