Skip to content

Conversation

@fisker
Copy link
Collaborator

@fisker fisker commented Feb 28, 2025

No description provided.

Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fails on our older builds so we'll have to wait until we drop support here.

Having said that; maybe it's worth simply removing husky? We have CI which will run tests & lint, and we squash PRs into 1 commit, so I am not sure there's much value in doing it during commit.

@fisker
Copy link
Collaborator Author

fisker commented Mar 1, 2025

Make sense to remove the format and ESLint fix on commit.
But after a second thought, it also runs commitlint for commit messages, maybe worth to keep it?

fisker added 2 commits March 1, 2025 22:09
# Conflicts:
#	package-lock.json
#	package.json
# Conflicts:
#	package-lock.json
#	package.json
@keithamus keithamus merged commit 26857d5 into keithamus:main Mar 4, 2025
2 checks passed
@fisker fisker deleted the husky branch March 4, 2025 15:36
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants