feat: added support for ignore pattern to cli #329
Merged
+50
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defaults to node_modules resolves keithamus#328
keithamus
reviewed
Nov 23, 2024
cli.js
Outdated
Comment on lines
63
to
69
| if (process.env.DEBUG) { | ||
| console.log([ | ||
| performance.measure('Glob Search', 'start', 'sorting'), | ||
| performance.measure('Sorting', 'sorting', 'finish'), | ||
| performance.measure('Total', 'start', 'finish'), | ||
| ]) | ||
| } |
There was a problem hiding this comment.
Can we remove this one please? I'd prefer to avoid shipping debug code. It's easy enough to add in for those interested in debugging.
added 3 commits
November 23, 2024 13:53
- CR Fixes resolves keithamus#328
- Fix snapshots resolves keithamus#328
- Little fix for ordering of parameters resolves keithamus#328
keithamus
approved these changes
Nov 23, 2024
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #328