fix: use locale-independent comparison for sorting of overrides #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
reviewed
Nov 18, 2024
Co-authored-by: Keith Cirkel <[email protected]>
keithamus
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 2.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this package is to format the package.json files always in the same way. But the
sortObjectBySemverfunction uses locale comparison for package names. Some locales have different sorting rules so the result can be different on other machines with various locales.For example, the Czech locale 'cs' puts 'ch' after the 'g' letter.
We should sort using locale-independent string sorting.