-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow sort scripts
without run-s
#277
base: main
Are you sure you want to change the base?
feat: allow sort scripts
without run-s
#277
Conversation
1df19f0
to
daf60d1
Compare
daf60d1
to
5a1065a
Compare
@fisker I don't think the Node 12 is about something I've done in this PR, so this one can be merged if everything seems fine to you? |
So, you really think my suggestion should only apply to just one of the patterns? |
The node failures we can look into. We may need to drop node 12 support shortly. |
@fisker Oh I thought it was meant to only have it on one of the regexes.
@keithamus The problems with Node v12 CI is because we're always updating to latest |
5a1065a
to
f1a480b
Compare
If you could please rebase, I've dropped that step in CI. |
f1a480b
to
dd8c480
Compare
@keithamus CI is passing on Node 12 now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll let @fisker get a final look before merge.
I need more time, but I have to go outside now, will be back in few hours. |
run-p
scripts
without run-s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fisker It's probably out of scope for this PR, but what would you think about adding support for sorting all scripts, except the one's mentioned by run-s
/-s
/--sequential
?
So basically
{
"scripts": {
"test": "jest",
"foo": "lint",
"build": "build:*",
"build:foo": "npm run foo",
"build:bar": "npm run bar",
"bar": "npm run test"
}
}
will become
{
"scripts": {
"bar": "npm run test",
"build": "build:*",
"build:foo": "npm run foo",
"build:bar": "npm run bar",
"foo": "lint",
"test": "jest"
}
}
Good, but maybe hard to implement. |
In my personal projects I don't do it either, but I've come across it in open source & work projects For example: when using Remix, it's important that Don't want to hold back on this PR for that though, so for me this one is approved as well 👍 (can't do it on GitHub, as I created the PR) |
Re-submission of #240
CC/ @keithamus @fisker