feat: sort regardless of devDependencies #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package does not currently support sorting the scripts field of a package.json when
npm-run-allis a devDependency.This PR proposes that
sort-package-jsonshould sort package.json, not create these exceptions, and revert those changes. They are unpredictable and hard to detect even with proper documentation.npm-run-allis likely not the only cli that can be concerned with script order and handling more of them isn't feasible. This has been brought up many times (#206, #220, #240, #242) and, since there are ultimately two conflicting schools of thought with no mitigation that allows both to exist, requiressort-package-jsonto pick one way or the other.