fix: missing type check on sortScripts (#139)

* fix: missing type check on `sortScripts` * perf: skip type check inside `sortScripts`
keithamus · Jan 10, 2020 · 869178f · 869178f
1 parent 195a6b7
commit 869178f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -113,7 +113,7 @@ const defaultNpmScripts = new Set([
   'version',
 ])
 
-const sortScripts = scripts => {
+const sortScripts = onObject(scripts => {
   const names = Object.keys(scripts)
   const prefixable = new Set()
 
@@ -136,8 +136,8 @@ const sortScripts = scripts => {
     [],
   )
 
-  return sortObjectBy(order)(scripts)
-}
+  return sortObjectKeys(scripts, order)
+})
 
 // fields marked `vscode` are for `Visual Studio Code extension manifest` only
 // https://code.visualstudio.com/api/references/extension-manifest

diff --git a/tests/_helpers.js b/tests/_helpers.js
@@ -85,8 +85,8 @@ function asItIs(t, { path, options }, excludeTypes = []) {
     )
   }
 
-  for (const value of ['string', false, 2020]) {
-    const type = typeof value
+  for (const value of ['string', false, 2020, undefined, null]) {
+    const type = value === null ? 'null' : typeof value
     if (!excludeTypes.includes(type)) {
       t.is(
         sortPackageJsonAsObject({ path, value, options }),