Rewrite lexer #50
Merged
Rewrite lexer #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I figured I'd start small so that I'm sure I'm not doing something really wrong. I'll make bigger changes as I go along.
Stacked PR against #34 --------- Co-authored-by: Keith Cirkel <[email protected]>
How does this look? Is this correct? Should I peek and store that in a variable for performance? Or readability? --------- Co-authored-by: Keith Cirkel <[email protected]>
I messed around some more. Not 100% sure this is the correct way to do this still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a rewrite...