TagsEdit code improvements and crash fix

Fix crash when pressing home on empty tag field

Move completer to TagsEdit.
Move cursor blink status to TagsEdit.
Move paint implementation to impl.
Simplify calcRect and drawTag.

Hide editing_index and cursor position.
Fix bug where an empty tag was shown if the tag edit was unfocused.
Fix a bug where the scollbar was not updated when a tag was removed.

Hide remaining TextEdit internal fields.
Refactor to use QLinkedList.
Remove obsolete EmptyTagIterator.
Encapsulate tags and selected index in tags manager.

src/gui/EntryPreviewWidget.cpp

@@ -402,7 +402,7 @@ void EntryPreviewWidget::updateEntryGeneralTab()
     const TimeInfo entryTime = m_currentEntry->timeInfo();
     const QString expires = entryTime.expires() ? Clock::toString(entryTime.expiryTime().toLocalTime()) : tr("Never");
     m_ui->entryExpirationLabel->setText(expires);
-    m_ui->entryTagsList->tags(m_currentEntry->tagList());
+    m_ui->entryTagsList->setTags(m_currentEntry->tagList());
     m_ui->entryTagsList->setReadOnly(true);
 }
 

src/gui/entry/EditEntryWidget.cpp

@@ -948,8 +948,8 @@ void EditEntryWidget::setForms(Entry* entry, bool restore)
     m_mainUi->usernameComboBox->lineEdit()->setReadOnly(m_history);
     m_mainUi->urlEdit->setReadOnly(m_history);
     m_mainUi->passwordEdit->setReadOnly(m_history);
-    m_mainUi->tagsList->tags(entry->tagList());
-    m_mainUi->tagsList->completion(m_db->tagList());
+    m_mainUi->tagsList->setTags(entry->tagList());
+    m_mainUi->tagsList->setCompletion(m_db->tagList());
     m_mainUi->expireCheck->setEnabled(!m_history);
     m_mainUi->expireDatePicker->setReadOnly(m_history);
     m_mainUi->revealNotesButton->setIcon(icons()->onOffIcon("password-show", false));

src/gui/entry/EditEntryWidgetMain.ui

@@ -143,13 +143,25 @@
      </widget>
     </item>
     <item row="5" column="1">
-     <widget class="TagsEdit" name="tagsList" native="true">
+     <widget class="TagsEdit" name="tagsList">
+      <property name="maximumSize">
+       <size>
+        <width>16777215</width>
+        <height>70</height>
+       </size>
+      </property>
       <property name="focusPolicy">
        <enum>Qt::StrongFocus</enum>
       </property>
       <property name="accessibleName">
        <string>Tags list</string>
       </property>
+      <property name="frameShape">
+       <enum>QFrame::Panel</enum>
+      </property>
+      <property name="sizeAdjustPolicy">
+       <enum>QAbstractScrollArea::AdjustToContents</enum>
+      </property>
      </widget>
     </item>
     <item row="7" column="1">
@@ -345,7 +357,7 @@
  <customwidgets>
   <customwidget>
    <class>TagsEdit</class>
-   <extends>QWidget</extends>
+   <extends>QScrollArea</extends>
    <header>gui/tag/TagsEdit.h</header>
    <container>1</container>
   </customwidget>