Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove internal devtools from release notes #1004

Merged
merged 7 commits into from
Feb 10, 2025
Merged

chore: remove internal devtools from release notes #1004

merged 7 commits into from
Feb 10, 2025

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Feb 7, 2025 •
edited
Loading

Description

The change to use detect-secrets instead of trufflehog doesn't affect users.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@deepyaman deepyaman marked this pull request as ready for review February 7, 2025 16:21
astrojuanlu
astrojuanlu approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍🏼 Although not sure what's our usual policy with these internal changes

merelcht
merelcht approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agreed this shouldn't be in the release notes 👍

@merelcht merelcht enabled auto-merge (squash) February 10, 2025 16:10
@merelcht merelcht merged commit da04be6 into main Feb 10, 2025
51 checks passed
@merelcht merelcht deleted the deepyaman-patch-2 branch February 10, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@merelcht merelcht merelcht approved these changes

@ElenaKhaustova ElenaKhaustova Awaiting requested review from ElenaKhaustova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepyaman @astrojuanlu @merelcht