New Solace Direct Messaging Scaler #6546
Open
+1,403
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
…scarded messages while scaling up Signed-off-by: Alfonso Chacón <[email protected]>
- Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: alfonso-chacon <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Alfonso Chacón <[email protected]>
* Code Cleanup - CodeQL/StaticChecks
Signed-off-by: Alfonso Chacón <[email protected]>
* Code cleanup /golangci-lint
Signed-off-by: Alfonso Chacón <[email protected]>
Signed-off-by: Alfonso Chacón <[email protected]>
JorTurFer
reviewed
Feb 14, 2025
| return meta, nil | ||
| } | ||
|
|
||
| // Interface required method!! |
There was a problem hiding this comment.
Suggested change
| // Interface required method!! |
Comment on lines
+381
to
+432
| if s.configuration.AggregatedClientTxByteRateTarget > 0 { | ||
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientTxByteRateTargetMetricName)) | ||
| externalMetric := &v2.ExternalMetricSource{ | ||
| Metric: v2.MetricIdentifier{ | ||
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | ||
| }, | ||
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientTxByteRateTarget), | ||
| } | ||
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | ||
| metricSpecList = append(metricSpecList, metricSpec) | ||
| } | ||
| // | ||
| // Target Client AverageTxByteRate | ||
| if s.configuration.AggregatedClientAverageTxByteRateTarget > 0 { | ||
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientAverageTxByteRateTargetMetricName)) | ||
| externalMetric := &v2.ExternalMetricSource{ | ||
| Metric: v2.MetricIdentifier{ | ||
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | ||
| }, | ||
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientAverageTxByteRateTarget), | ||
| } | ||
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | ||
| metricSpecList = append(metricSpecList, metricSpec) | ||
| } | ||
| // | ||
| // Target Client TxMsgRate | ||
| if s.configuration.AggregatedClientTxMsgRateTarget > 0 { | ||
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientTxMsgRateTargetMetricName)) | ||
| externalMetric := &v2.ExternalMetricSource{ | ||
| Metric: v2.MetricIdentifier{ | ||
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | ||
| }, | ||
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientTxMsgRateTarget), | ||
| } | ||
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | ||
| metricSpecList = append(metricSpecList, metricSpec) | ||
| } | ||
| // | ||
| // Target Client AverageTxMsgRate | ||
| if s.configuration.AggregatedClientAverageTxMsgRateTarget > 0 { | ||
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientAverageTxMsgRateTargetMetricName)) | ||
| externalMetric := &v2.ExternalMetricSource{ | ||
| Metric: v2.MetricIdentifier{ | ||
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | ||
| }, | ||
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientAverageTxMsgRateTarget), | ||
| } | ||
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | ||
| metricSpecList = append(metricSpecList, metricSpec) | ||
| } | ||
|
|
||
| return metricSpecList |
There was a problem hiding this comment.
Let's unify this code just calculating the metricName and the value for the target with the ifs and unifying the other code:
Suggested change
| if s.configuration.AggregatedClientTxByteRateTarget > 0 { | |
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientTxByteRateTargetMetricName)) | |
| externalMetric := &v2.ExternalMetricSource{ | |
| Metric: v2.MetricIdentifier{ | |
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | |
| }, | |
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientTxByteRateTarget), | |
| } | |
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | |
| metricSpecList = append(metricSpecList, metricSpec) | |
| } | |
| // | |
| // Target Client AverageTxByteRate | |
| if s.configuration.AggregatedClientAverageTxByteRateTarget > 0 { | |
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientAverageTxByteRateTargetMetricName)) | |
| externalMetric := &v2.ExternalMetricSource{ | |
| Metric: v2.MetricIdentifier{ | |
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | |
| }, | |
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientAverageTxByteRateTarget), | |
| } | |
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | |
| metricSpecList = append(metricSpecList, metricSpec) | |
| } | |
| // | |
| // Target Client TxMsgRate | |
| if s.configuration.AggregatedClientTxMsgRateTarget > 0 { | |
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientTxMsgRateTargetMetricName)) | |
| externalMetric := &v2.ExternalMetricSource{ | |
| Metric: v2.MetricIdentifier{ | |
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | |
| }, | |
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientTxMsgRateTarget), | |
| } | |
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | |
| metricSpecList = append(metricSpecList, metricSpec) | |
| } | |
| // | |
| // Target Client AverageTxMsgRate | |
| if s.configuration.AggregatedClientAverageTxMsgRateTarget > 0 { | |
| metricName := kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientAverageTxMsgRateTargetMetricName)) | |
| externalMetric := &v2.ExternalMetricSource{ | |
| Metric: v2.MetricIdentifier{ | |
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | |
| }, | |
| Target: GetMetricTarget(s.metricType, s.configuration.AggregatedClientAverageTxMsgRateTarget), | |
| } | |
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | |
| metricSpecList = append(metricSpecList, metricSpec) | |
| } | |
| return metricSpecList | |
| metricName := "" | |
| target := 1 | |
| if s.configuration.AggregatedClientTxByteRateTarget > 0 { | |
| metricName : kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientTxByteRateTargetMetricName)) | |
| target = s.configuration.AggregatedClientTxByteRateTarget | |
| } | |
| // | |
| // Target Client AverageTxByteRate | |
| if s.configuration.AggregatedClientAverageTxByteRateTarget > 0 { | |
| metricName = kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientAverageTxByteRateTargetMetricName)) | |
| target = s.configuration.AggregatedClientAverageTxByteRateTarget | |
| } | |
| // | |
| // Target Client TxMsgRate | |
| if s.configuration.AggregatedClientTxMsgRateTarget > 0 { | |
| metricName = kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientTxMsgRateTargetMetricName)) | |
| target = s.configuration.AggregatedClientTxMsgRateTarget | |
| } | |
| // | |
| // Target Client AverageTxMsgRate | |
| if s.configuration.AggregatedClientAverageTxMsgRateTarget > 0 { | |
| metricName = kedautil.NormalizeString(fmt.Sprintf("solace-dm-%s-%s", clientNamePattern, aggregatedClientAverageTxMsgRateTargetMetricName)) | |
| target = s.configuration.AggregatedClientAverageTxMsgRateTarget | |
| } | |
| externalMetric := &v2.ExternalMetricSource{ | |
| Metric: v2.MetricIdentifier{ | |
| Name: GenerateMetricNameWithIndex(triggerIndex, metricName), | |
| }, | |
| Target: GetMetricTarget(s.metricType, target), | |
| } | |
| metricSpec := v2.MetricSpec{External: externalMetric, Type: solaceDMExternalMetricType} | |
| metricSpecList = append(metricSpecList, metricSpec) | |
| return metricSpecList |
| return metricSpecList | ||
| } | ||
|
|
||
| // Interface required method!! |
There was a problem hiding this comment.
Suggested change
| // Interface required method!! |
| return []external_metrics.ExternalMetricValue{}, false, err | ||
| } | ||
|
|
||
| s.logger.Info(fmt.Sprintf("Metrics: '%s'", metricValues)) |
There was a problem hiding this comment.
let's move to debug
Suggested change
| s.logger.Info(fmt.Sprintf("Metrics: '%s'", metricValues)) | |
| s.logger.V(1).Info(fmt.Sprintf("Metrics: '%s'", metricValues)) |
| return []external_metrics.ExternalMetricValue{metric}, true, nil | ||
| } | ||
|
|
||
| // Interface required method!! |
There was a problem hiding this comment.
Suggested change
| // Interface required method!! |
|
/run-e2e solace_dm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Solace Direct Messaging Scaler Added
Checklist
Fixes #
Relates to #
[#6545] (#6545) - Issue
[#1537] (kedacore/keda-docs#1537) - Documentation