Add option to the Datadog scaler to use the Cluster Agent as proxy #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arapulido
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arapulido
force-pushed
the
cluster_agent_proxy
branch
from
76f8249
to
76a58a9
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
/run-e2e datadog |
stale
bot
removed
the
stale
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
zroubalik
reviewed
Jun 10, 2024
stale
bot
removed
the
stale
|
@zroubalik I will now continue this work. I need to rebase and I will ask for reviews soon |
arapulido
force-pushed
the
cluster_agent_proxy
branch
from
76a58a9
to
d3984a6
Compare
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
arapulido
force-pushed
the
cluster_agent_proxy
branch
from
20e7540
to
66a1b57
Compare
Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: Ara Pulido <[email protected]>
|
@zroubalik this is ready to be reviewed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to the Datadog scaler to use the Datadog Cluster Agent as proxy to obtain the metrics, instead of calling the REST API directly.
This avoids duplication and also improves the rate limiting issue that the Datadog scaler currently has, as the Cluster Agent gets the metric values in batches.
Implements: #5355
Checklist
Fixes #5355
Relates to #