Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose keda_scaler_metrics_value metric for scaledJob #5134

Closed
wants to merge 1 commit into from

Conversation

woehrl01
Copy link

@woehrl01 woehrl01 commented Oct 29, 2023

Provide a description of what has been changed

Currently keda_scaler_metrics_value is only exposed for ScaledObjects, but not for ScaledJobs I don't see a reason why the metric should not be exposed for ScaledJobs, too. So this PR adds that metric.

Checklist

Fixes #

Relates to #

@woehrl01 woehrl01 requested a review from a team as a code owner October 29, 2023 14:09
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@woehrl01 woehrl01 force-pushed the scaled_job_prom_metrics branch from 7d3938f to 6a63a18 Compare October 29, 2023 14:10
@woehrl01 woehrl01 changed the title feat: expose prometheus metric for scaledJob, too feat: expose keda_scaler_metrics_value metric for scaledJob Oct 29, 2023
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right and we should expose the metrics, but current metric is attached to ScaledObject (it has a label named scaledObject), I'd say that we should create a new metric for unifying both, splitting them by label. e.g: internal_scale_loop

Could you add a test for the new metric too? There are test cases for prometheus and otel: https://github.com/kedacore/keda/tree/main/tests/sequential

Copy link

stale bot commented Jan 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 11, 2024
Copy link

stale bot commented Jan 19, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants