Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the azure pipeline property requireAllDemandsAndIgnoreOthers #1496

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Nohac
Copy link
Contributor

@Nohac Nohac commented Nov 7, 2024

Add documentation for the new requireAllDemandsAndIgnoreOthers property

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#5579

@Nohac Nohac requested a review from a team as a code owner November 7, 2024 09:22
Copy link

github-actions bot commented Nov 7, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 4587601
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/67a653def3451c000836a204
😎 Deploy Preview https://deploy-preview-1496--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this to 2.17

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nohac please fix the DCO

@Nohac
Copy link
Contributor Author

Nohac commented Feb 7, 2025

@zroubalik It should already be fixed, I've added the signed off line and force pushed, not sure why it's not working..
image

@zroubalik
Copy link
Member

@zroubalik It should already be fixed, I've added the signed off line and force pushed, not sure why it's not working.. image

The DCO suggests https://github.com/kedacore/keda-docs/pull/1496/checks?check_run_id=36551161588:

To add your Signed-off-by line to every commit in this branch:

    Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
    In your local branch, run: git rebase HEAD~1 --signoff
    Force push your changes to overwrite the branch: git push --force-with-lease origin main

@JorTurFer JorTurFer merged commit 42323b3 into kedacore:main Feb 10, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending the Azure DevOps Agent scaling - possibility to "ignore" demands
3 participants