-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Copy to Clipboard for FAQ #1303
Conversation
Signed-off-by: thisisobate <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton!
Just a few suggestions:
- Can we make the button less explicit? It's pretty invasive but it might be me, @zroubalik/@JorTurFer ?
I agree with all your points 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @tomkerkhove
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
@tomkerkhove I suggest we do the troubleshooting part in a separate PR. |
Sounds good! |
Signed-off-by: thisisobate <[email protected]>
@tomkerkhove How about this? ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: thisisobate <[email protected]>
@zroubalik Yes, we do. |
Signed-off-by: thisisobate <[email protected]>
Works like a charm, thanks! However, it no longer auto-expands which it used to do though :( |
@tomkerkhove Actually, it does expand. It looks like you tried loading the FAQ link in the same tab. |
Hm, why would that not work? It's not a blocker but curious though |
So here's a bit of an explanation of why it won't work:, Hope that helps. |
Thanks! |
Todos
Fixes #1274