Introduce event filter in CloudEventSource #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
tomkerkhove
suggested changes
Jan 27, 2024
There was a problem hiding this comment.
I'm not sure I get this PR, are we missing changes for filtering, @SpiritZhou ?
SpiritZhou
force-pushed
the
cloudeventsourcefilter
branch
from
bfb9e36 to
f7ddb0d
Compare
Signed-off-by: SpiritZhou <[email protected]>
SpiritZhou
force-pushed
the
cloudeventsourcefilter
branch
from
f7ddb0d to
4cfb1f3
Compare
Sorry, I might have messed up when merging main branch. |
tomkerkhove
reviewed
Feb 20, 2024
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: SpiritZhou <[email protected]>
tomkerkhove
approved these changes
Mar 23, 2024
JorTurFer
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce event filter in CloudEventSource
Checklist
Fixes #
kedacore/keda#5424