Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ScaledObject docs have all the anchors #1286

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 5, 2024

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@JorTurFer JorTurFer requested a review from a team as a code owner January 5, 2024 11:27
Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9d2145a
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6597e793bfc44400089dff2d
😎 Deploy Preview https://deploy-preview-1286--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 5, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer
Copy link
Member Author

Adding the titles to the lateral menu would be nice:
image

But at least now they have anchors that we can link for sharing info

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I like it

@JorTurFer
Copy link
Member Author

@tomkerkhove , do yuu know if we can include them in the menu too?

@tomkerkhove tomkerkhove merged commit 3f45fb2 into kedacore:main Jan 8, 2024
8 checks passed
@JorTurFer JorTurFer deleted the concepts branch January 8, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants