Fixed devices not showing up on subscription page #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device column in the subscription page only showed ?? as there where no device data stored in the DB, this is fixed in this commit. Also added an additional column in the subscription page that shows some more info about the registered action, currently only the play position is displayed but it could be extended in the future.
|
Fetching the device ID for each episode action would be too slow, as we can add thousands of actions at the same time… |
|
Storing the device ID string would be a alternative but it would take more storage in the DB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device column in the subscription page only showed ?? as there where no device data stored in the DB, this is fixed in this commit.
Also added an additional column in the subscription page that shows some more info about the registered action, currently only the play position is displayed but it could be extended in the future.