Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Partially revert 3105 to not run goreleaser multiple times #3125

Merged
merged 1 commit into from
May 3, 2024

Conversation

embik
Copy link
Member

@embik embik commented May 3, 2024

Summary

In #3105, we added additional triggers to the goreleaser action, but it seems to me that had unintended consequences, namely #3121 -- now the action runs three times, and all three of them tried to upload binaries to the release:

Looks like they raced to upload artefacts, and now the checksum file (which came from one of these jobs) doesn't match all uploaded artefacts (since they came from different jobs). I'm not sure if prerelease: auto should be removed, so I'm only reverting the triggers since they are the root cause for this behaviour.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 3, 2024
@embik
Copy link
Member Author

embik commented May 3, 2024

/cc @mjudeikis @sttts

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2024
@kcp-ci-bot kcp-ci-bot requested review from mjudeikis and sttts May 3, 2024 06:57
@embik embik changed the title 🐛 Partially revert #3105 to not run goreleaser multiple times 🐛 Partially revert 3105 to not run goreleaser multiple times May 3, 2024
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b293dfe7d8910dc08134b649513f4af3fcd06d0

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@kcp-ci-bot kcp-ci-bot merged commit eade9cd into kcp-dev:main May 3, 2024
13 of 14 checks passed
@embik embik deleted the revert-3105 branch May 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants