Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ✨ Fix CPU consumption #3062

Open
wants to merge 4 commits into
base: release-0.21
Choose a base branch
from

Conversation

PavitraS
Copy link

@PavitraS PavitraS commented Dec 18, 2023

Summary

Encountering performance challenges with KCP when dealing with just 100 workspaces. The issues are attributed to

  1. protomodels,
  2. CR CEL validation, and
  3. quota controller.

In an effort to provide a solution, this commit disables the following functionalities:

  1. Disabling openapi.ToProtoModels.
  2. Disabling CR validation expression feature.
  3. Disabling the quota controller.

Related issue(s)

Fixes #3063

Release Notes

TODO: before merge

NONE

Signed-off-by: pavithra <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2023
@kcp-ci-bot
Copy link
Contributor

Hi @PavitraS. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PavitraS PavitraS changed the title Disable proto #3063 - Disable proto Dec 18, 2023
@PavitraS PavitraS changed the title #3063 - Disable proto Disable proto Dec 18, 2023
@PavitraS PavitraS changed the title Disable proto 🌱 Fix CPU consumption Dec 18, 2023
@PavitraS PavitraS changed the title 🌱 Fix CPU consumption ✨ Fix CPU consumption Dec 18, 2023
@palnabarun
Copy link
Member

/ok-to-test

@PavitraS can you also attach the heap profile here along with a screengrab of the hot paths?

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2023
@embik
Copy link
Member

embik commented Dec 18, 2023

This PR is targeting release-0.21. Can we please propose merging it into main first and then see if we want to back port it?

Signed-off-by: pavithra <[email protected]>
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2023
@PavitraS
Copy link
Author

/ok-to-test

Signed-off-by: pavithra <[email protected]>
Signed-off-by: pavithra <[email protected]>
@sttts
Copy link
Member

sttts commented Dec 26, 2023

What are the consequences?

No way to fix the root causes?

@embik embik changed the title ✨ Fix CPU consumption WIP: ✨ Fix CPU consumption Jan 18, 2024
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@mjudeikis mjudeikis added this to the 1.30-rebase milestone Jan 23, 2024
@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@sttts
Copy link
Member

sttts commented Apr 23, 2024

/remove-lifecycle stale

Keeping this open as it is a good reminder of the work to be done.

@kcp-ci-bot kcp-ci-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants