🌱 Set worker count to 10 everywhere #2699
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
New changes are detected. LGTM label has been removed. |
ncdc
force-pushed
the
consistent-controller-workers
branch
2 times, most recently
from
7356e88
to
ffc56b2
Compare
| @@ -89,7 +89,7 @@ func TestServerWithClientCAFile(clientCAFile string) []string { | |||
| // start a test server with the given token auth file. | |||
| func TestServerArgsWithTokenAuthFile(tokenAuthFile string) []string { | |||
| return []string{ | |||
| "-v=4", | |||
There was a problem hiding this comment.
It's for debugging the failures
There was a problem hiding this comment.
for debugging sure, but to merge? We already went from 2 to 4 sometime ago. Now 5?
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
openshift-merge-robot
added
the
needs-rebase
ncdc
force-pushed
the
consistent-controller-workers
branch
from
ffc56b2
to
3290979
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
ncdc
force-pushed
the
consistent-controller-workers
branch
from
3290979
to
ec68ca8
Compare
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
Skip deleting bound resources in the logicalcluster deletor as this can race with the apibinding deletion controller. If the apibinding deletion controller deletes an APIBinding and all its instances and then the logicalcluster deletor tries to delete the collection of the same resources (because it saw the resource in discovery), it will get a 404 and go into rate limited backoff, which we don't want. Signed-off-by: Andy Goldstein <[email protected]>
|
@ncdc: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
added
the
needs-rebase
|
@ncdc I assume we still want this? |
|
Yes, I think so. I still haven't figured out why this consistently causes content deletion to fail/flake. |
|
Replaced by #2960 |
|
@ncdc: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.