Skip to content

Conversation

@embik
Copy link
Member

@embik embik commented Jan 8, 2025

Summary

Controller RBAC wasn't updated with the resources that the reconcilers needed to access, so this updates the RBAC markers and generated RBAC.

Related issue(s)

Fixes #

Release Notes

NONE

@embik embik requested a review from xrstf January 8, 2025 07:59
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik embik force-pushed the add-rbac-markers branch from 212f30e to 7d505d8 Compare January 8, 2025 08:24
@xrstf
Copy link
Contributor

xrstf commented Jan 8, 2025

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9740f28cf6934469507f22c0ead7c3e4c593d556

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@kcp-ci-bot kcp-ci-bot merged commit 49432da into kcp-dev:main Jan 8, 2025
10 checks passed
@embik embik deleted the add-rbac-markers branch January 8, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants