Skip to content

rename logLevel to logging, cleanup API, fix codegen script #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcp-ci-bot merged 1 commit into from
Oct 20, 2025
Merged

rename logLevel to logging, cleanup API, fix codegen script #119

kcp-ci-bot merged 1 commit into from
Oct 20, 2025

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 20, 2025 •
edited
Loading

Summary

This renames the previously (#116) introduced spec.logLevel field to spec.logging, because logLevel.verbosityLevel was sooo redundant. I kept the substructure because I can imagine more logging options being added in the future.

I also fixed the codegen scribt, which left behind files previously.

What Type of PR Is This?

/kind api-change

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2025
@mjudeikis
Copy link
Contributor

mjudeikis commented Oct 20, 2025

/retest

1 similar comment
@mjudeikis
Copy link
Contributor

mjudeikis commented Oct 20, 2025

/retest

@xrstf xrstf force-pushed the improve-logging-api branch from c8ae5d7 to f5318a5 Compare October 20, 2025 13:30
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 20, 2025 •
edited
Loading

@xrstf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-operator-test-e2e-canary f5318a5 link false /test pull-kcp-operator-test-e2e-canary

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xrstf
Copy link
Contributor Author

xrstf commented Oct 20, 2025

/retest

@mjudeikis
Copy link
Contributor

mjudeikis commented Oct 20, 2025

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 20, 2025

LGTM label has been added.

Git tree hash: 15c84d34420c984af0e9a3d4c857303ca1ce7d75

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@kcp-ci-bot kcp-ci-bot merged commit e6e5e96 into kcp-dev:main Oct 20, 2025
9 of 10 checks passed
@xrstf xrstf deleted the improve-logging-api branch October 20, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xrstf @mjudeikis @kcp-ci-bot