Skip to content

Conversation

@olamilekan000
Copy link
Contributor

Summary

change implements cross namespace reference for ectd secret

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes 99

Release Notes

Add cross namespace secret reference for etcd secret

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 18, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrstf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olamilekan000 olamilekan000 marked this pull request as draft October 18, 2025 13:28
@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2025
@olamilekan000
Copy link
Contributor Author

I'll be closing because Volumes needs to access the secret from the same namespace as the Pod, trying to make secret namespaced scoped at the moment, won't work.

podSpec.Volumes = append(podSpec.Volumes, corev1.Volume{
	Name: volumeName,
	VolumeSource: corev1.VolumeSource{
		Secret: &corev1.SecretVolumeSource{
			SecretName: config.TLSConfig.SecretRef.Name,
		},
	},
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Allow cross-namespaces etcd secret references

2 participants