Skip to content

Update to Go 1.24.8 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcp-ci-bot merged 3 commits into from
Oct 10, 2025
Merged

Update to Go 1.24.8 #112

kcp-ci-bot merged 3 commits into from
Oct 10, 2025

Conversation

@embik
Copy link
Member

@embik embik commented Oct 10, 2025

Summary

Updates our Go version to the latest 1.24 release. Previous attempt #104 was used for debugging.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Towards kcp-dev/infra#136

Release Notes

kcp-operator is built with Go 1.24.8

@embik
Update to Go 1.24.8
c8c7ce7 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik embik requested a review from xrstf October 10, 2025 12:24
@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2025
@embik embik marked this pull request as draft October 10, 2025 12:26
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@embik embik marked this pull request as ready for review October 10, 2025 12:38
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@embik
Pin kindest/node image to v1.32.2
17c66a7 
For details, see
kcp-dev/infra@f4567ed.

On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Oct 10, 2025

/retest

@embik
Copy link
Member Author

embik commented Oct 10, 2025

/cherry-pick release-0.2

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 10, 2025

@embik: once the present PR merges, I will cherry-pick it on top of release-0.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented Oct 10, 2025

/approve

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
xrstf
xrstf approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 10, 2025

LGTM label has been added.

Git tree hash: 3a694af1d7bdaa978a1a1ee96a63ec93a237d481

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot merged commit 52e494a into kcp-dev:main Oct 10, 2025
10 checks passed
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 10, 2025

@embik: #112 failed to apply on top of branch "release-0.2":

Applying: Update to Go 1.24.8
Applying: Adjust image tag discovery to longer git hashes produced by kcp-dev/kcp
Applying: Pin kindest/node image to v1.32.2
Using index info to reconstruct a base tree...
M	hack/ci/run-e2e-tests.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/ci/run-e2e-tests.sh
CONFLICT (content): Merge conflict in hack/ci/run-e2e-tests.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Pin kindest/node image to v1.32.2
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik embik deleted the go-1.24.8-3 branch October 10, 2025 13:41
This was referenced Oct 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@embik @kcp-ci-bot @xrstf