Merge pull request #217 from kbase/sdkdev

Fix MacOS x64 builds +  TODO / typo cleanup

Author: MrCreosote

.github/workflows/native_binary_build.yml

@@ -26,7 +26,7 @@ jobs:
             label: linux-x64
           - os: macos-14
             label: macos-arm64
-          - os: macos-13
+          - os: macos-15-intel
             label: macos-x64
 
     runs-on: ${{ matrix.os }}

.github/workflows/native_binary_release.yml

@@ -18,7 +18,7 @@ jobs:
             label: linux-x64
           - os: macos-14
             label: macos-arm64
-          - os: macos-13
+          - os: macos-15-intel
             label: macos-x64
 
     runs-on: ${{ matrix.os }}

build.gradle

@@ -5,17 +5,11 @@ plugins {
 	id 'org.graalvm.buildtools.native' version '0.10.6'
 }
 
-// TODO BUILD look into GraalVM native compilation vs. dockerizing kb-sdk
-//             https://github.com/oracle/graal/issues/407#issuecomment-2573704305
-// TODO GENSCRIPT need to update genscript if we don't switch to GraalVM. Need to release to get
-//                a latest tag
 
 // TODO TEST DEPS TypeGeneratorTest has a hard coded list of jars it uses for tests
 //           Need to figure out a better way
 // TODO TEST add a test that starts the SDK in a docker container and checks some simple cmds
-// TODO DEPS make JitPack jars for catalog and NMS and use them
-
-// TODO CODE move all code under us.kbase.sdk
+//           EDIT - run against the kb-sdk+ binary
 
 group = 'us.kbase.sdk'
 

src/main/java/us/kbase/sdk/callback/CallbackServerManager.java

@@ -60,7 +60,7 @@ public class CallbackServerManager implements AutoCloseable {
 	 * @param workDirRoot the working directory for the callback server. This directory will
 	 * be mounted into the server. Any files outside of this directory will not be visible to
 	 * the server. The callback server will write output here.
-	 * @param kbaseBaseUrl the base URL for contacting kBase services,
+	 * @param kbaseBaseUrl the base URL for contacting KBase services,
 	 * e.g. "https://ci.kbase.us/services/"
 	 * @param token the user's KBase token for contacting KBase services.
 	 * @param prov initial provenance for the callback server.