Skip to content

Commit 6f995c8

Browse files
authored
Merge pull request #193 from kbase/sdkdev
Use PyPi baseclient
2 parents 20feba5 + afd2711 commit 6f995c8

10 files changed

Lines changed: 79 additions & 392 deletions

File tree

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ requires-python = "==3.12.10"
77
dependencies = [
88
"jsonrpcbase>=0.2.0",
99
"kbase-auth-client==0.1.1",
10+
"kbase-sdk-baseclient==0.1.0",
1011
"requests>=2.32.3",
1112
]
1213

src/main/java/us/kbase/sdk/callback/CallbackServerManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ public class CallbackServerManager implements AutoCloseable {
6060
* @param workDirRoot the working directory for the callback server. This directory will
6161
* be mounted into the server. Any files outside of this directory will not be visible to
6262
* the server. The callback server will write output here.
63-
* @param kbaseBaseUrl the base URL for contacting kBase services, e.g. "https://ci.kbase.us"
63+
* @param kbaseBaseUrl the base URL for contacting kBase services,
64+
* e.g. "https://ci.kbase.us/services/"
6465
* @param token the user's KBase token for contacting KBase services.
6566
* @param prov initial provenance for the callback server.
6667
* @param setResultsGloballyWriteable if true, set all files in the workDirRoot/workdir and

src/main/java/us/kbase/sdk/compiler/TemplateBasedGenerator.java

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package us.kbase.sdk.compiler;
22

33
import java.io.File;
4-
import java.io.IOException;
54
import java.io.InputStream;
65
import java.io.Writer;
76
import java.nio.file.Path;
@@ -185,30 +184,14 @@ private static void initPythonPackages(String relativePyPath, FileSaver output,
185184
}
186185
}
187186

188-
if (client) {
189-
copyResourceFile(relativePyPath, output, "baseclient.py");
190-
} else {
191-
copyResourceFile("biokbase/log.py", output, "log.py");
192-
}
193-
}
194-
195-
private static void copyResourceFile(
196-
final String relativePath,
197-
final FileSaver output,
198-
final String file)
199-
throws IOException {
200-
final Path filepath;
201-
if (Paths.get(relativePath).getParent() == null) {
202-
filepath = Paths.get(file);
203-
} else {
204-
filepath = Paths.get(relativePath).getParent()
205-
.resolve(file);
206-
}
207-
try (
208-
final InputStream input = TemplateFormatter.getResource(file);
209-
final Writer w = output.openWriter(filepath.toString())
210-
) {
211-
IOUtils.copy(input, w);
187+
if (!client) {
188+
final Path filepath = Paths.get("biokbase/log.py");
189+
try (
190+
final InputStream input = TemplateFormatter.getResource("log.py");
191+
final Writer w = output.openWriter(filepath.toString())
192+
) {
193+
IOUtils.copy(input, w);
194+
}
212195
}
213196
}
214197

src/main/resources/us/kbase/sdk/templates/baseclient.py

Lines changed: 0 additions & 282 deletions
This file was deleted.

src/main/resources/us/kbase/sdk/templates/module_dockerfile.vm.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ ENV PATH=/sdk/bin:$PATH
3838
RUN pip install \
3939
requests==2.32.5 \
4040
kbase-auth-client==0.1.1 \
41+
kbase-sdk-baseclient==0.1.0 \
4142
jsonrpcbase==0.2.0 \
4243
uwsgi==2.0.30 \
4344
pytest==8.4.2 \

0 commit comments

Comments
 (0)