Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app estimator lookup function #121

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

briehl
Copy link
Member

@briehl briehl commented Jul 10, 2019

similar to other app lookup functions in catalog, can be run with:

catalog.get_app_resource_estimator({
    "module_name": "SomeModule",
    "app_id": "some_method",
    "tag": "release"
})

or

catalog.get_app_resource_estimator({
    "app_id": "some_nms_only_module"  # or "SomeModule.some_method"
})

returns

{
    "estimator_module": "SomeModule",
    "estimator_method": "an_estimator_method"
    "tag": "release"  # (or "beta" or "dev")
}

If an estimator isn't found, those values are null.

To get this to work right, I changed two things for testing.

  1. Changed the NMS submodule to the develop branch (that's only used for testing anyway)
  2. Changed the narrative_method_specs it uses to the test branch, which it should probably be using anyway.

Other than that, it's pretty straightforward. Main changes are in catalog.spec, controller.py, and app_estimator_test.py

@briehl
Copy link
Member Author

briehl commented Jul 10, 2019

@scanon @bio-boris ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant