-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tree diff comparison faster #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: b667b02 | Previous: 624500f | Ratio |
---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15951.354748357255 iter/sec (stddev: 0.0000037355037042374864 ) |
15036.881711807157 iter/sec (stddev: 0.000014651181796644849 ) |
0.94 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
653.7989445331834 iter/sec (stddev: 0.000014995754929732598 ) |
617.9078086494857 iter/sec (stddev: 0.00008027557012531534 ) |
0.95 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.49545870093483 iter/sec (stddev: 0.00042521661225705865 ) |
11.74360620035695 iter/sec (stddev: 0.0041793717421882755 ) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
68.81418677679169 iter/sec (stddev: 0.0031649088363212108 ) |
67.90202841386106 iter/sec (stddev: 0.002806823386236181 ) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22648.132944427634 iter/sec (stddev: 0.0000018292145321188504 ) |
22500.807217007812 iter/sec (stddev: 0.000007590862008507967 ) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1652.2312598369492 iter/sec (stddev: 0.0000073272525977627735 ) |
1726.4582313626418 iter/sec (stddev: 0.000012678848851225558 ) |
1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
117.02303829044452 iter/sec (stddev: 0.0032111117590907317 ) |
117.54816209747398 iter/sec (stddev: 0.003198325854272518 ) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
93.51908486750459 iter/sec (stddev: 0.003229896262862948 ) |
94.19110991901941 iter/sec (stddev: 0.0029674035885756617 ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
kayjan
changed the title
Make tree diff attribute comparison faster
Make tree diff comparison faster
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For attribute comparison
For path comparison
search.find_full_path
instead of relying on lengthy dataframe methodsTesting
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)