Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables in tree_diff #327

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Rename variables in tree_diff #327

merged 1 commit into from
Nov 12, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Nov 12, 2024

Description

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: c4161b7 Previous: 2698a4a Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 14862.032040751725 iter/sec (stddev: 0.000014411614016439523) 15248.644395425785 iter/sec (stddev: 0.00001745153677849208) 1.03
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 652.4116887379762 iter/sec (stddev: 0.000010010793543760842) 677.3043179766886 iter/sec (stddev: 0.00000927978655267549) 1.04
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 11.522776314318042 iter/sec (stddev: 0.003976981376534476) 11.735760967184865 iter/sec (stddev: 0.0036346469421306067) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 61.776229502104236 iter/sec (stddev: 0.004225930551796303) 64.48230099313099 iter/sec (stddev: 0.003910401404098519) 1.04
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 21392.18179909858 iter/sec (stddev: 0.000009765781042648353) 22518.1862505378 iter/sec (stddev: 0.000009148052559745382) 1.05
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1724.1811841969045 iter/sec (stddev: 0.00000925638132055234) 1726.9106647539315 iter/sec (stddev: 0.000006802296527203171) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 96.09703663501011 iter/sec (stddev: 0.005745862800498094) 98.00094007401637 iter/sec (stddev: 0.005266281909715983) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 82.89098352745862 iter/sec (stddev: 0.005024307918583827) 79.46717702817621 iter/sec (stddev: 0.005474960222419471) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2389 / 2389) 100% (1002 / 1002) 0

@kayjan kayjan merged commit 624500f into master Nov 12, 2024
6 checks passed
@kayjan kayjan deleted the feature/tree-diff-naming branch November 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant