Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iloc instead of df._append #319

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Nov 3, 2024

Description

Use iloc instead of _append for string replacement

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the enhancement New feature or request label Nov 3, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2388 / 2388) 100% (1006 / 1006) 0

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 82d5a6b Previous: ffb365f Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 15690.29861012362 iter/sec (stddev: 0.000016644374390569218) 15649.831881678416 iter/sec (stddev: 0.000015519791763159073) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 682.2609459135352 iter/sec (stddev: 0.0000024050822951363654) 671.2849279622427 iter/sec (stddev: 0.000017518994769491424) 0.98
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 12.404294718369169 iter/sec (stddev: 0.002830243469934769) 12.359152136060722 iter/sec (stddev: 0.0024753175143640595) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 70.56563287285414 iter/sec (stddev: 0.0029907409407855644) 70.44574162606288 iter/sec (stddev: 0.00287103115684229) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 23462.61232644463 iter/sec (stddev: 0.000007174871087123385) 22074.056251135735 iter/sec (stddev: 1.2890556959077393e-7) 0.94
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1672.2037513384219 iter/sec (stddev: 0.000011937588811718427) 1534.935437541866 iter/sec (stddev: 0.00007394243895384166) 0.92
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 118.115721858712 iter/sec (stddev: 0.0032469553553820885) 120.28216656665909 iter/sec (stddev: 0.003006444651024915) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 99.58142987372213 iter/sec (stddev: 0.0026286502964682377) 94.93906205761925 iter/sec (stddev: 0.003206307463487982) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan merged commit 4e85c7a into master Nov 3, 2024
6 checks passed
@kayjan kayjan deleted the bugfix/tree-diff-substring branch November 3, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant