Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model): #36 one dimensional harmonic oscillator chain #58

Merged
merged 44 commits into from
Aug 4, 2024
Merged

feat(model): #36 one dimensional harmonic oscillator chain #58

merged 44 commits into from
Aug 4, 2024

Conversation

cmp0xff
Copy link
Collaborator

@cmp0xff cmp0xff commented Jun 17, 2024 •
edited
Loading

with periodic boundary condition

@cmp0xff cmp0xff self-assigned this Jun 17, 2024
@cmp0xff cmp0xff linked an issue Jun 17, 2024 that may be closed by this pull request
One-dimensional circle of interacting harmonic oscillators #36
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

Coverage

Coverage Report (ee6258a, 3.11, ubuntu-latest)
FileStmtsMissCoverMissing
hamilflow
   __init__.py00100% 
hamilflow/models
   __init__.py00100% 
   brownian_motion.py4211 98%
   free_particle.py3222 94%
   harmonic_oscillator.py10688 92%
   harmonic_oscillator_chain.py4466 86%
   pendulum.py5677 88%
TOTAL2802491% 

Tests Skipped Failures Errors Time
1645 0 💤 0 ❌ 0 🔥 6.152s ⏱️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-04 20:09 UTC

@cmp0xff cmp0xff requested a review from emptymalei July 21, 2024 19:47
@cmp0xff cmp0xff marked this pull request as ready for review July 21, 2024 19:47
@cmp0xff cmp0xff mentioned this pull request Jul 23, 2024
Closed
cmp0xff added a commit that referenced this pull request Jul 23, 2024
@cmp0xff
feat(comment): #61 #58 (comment)
9cc7384
cmp0xff added a commit that referenced this pull request Jul 23, 2024
@cmp0xff
feat(comment): #61 reuse the class HarmonicOscillatorSystem to suppor…
1347914 
…t complex cases (#62)

* feat(comment): #61 #58 (comment)

* feat: #59 improve exception messages

* chore(typo): #61
cmp0xff and others added 4 commits July 24, 2024 21:03
@cmp0xff
feat(model): #59 make a class for linear motion (#60)
cd82da6 
* feat: #59 free particle

* chore(poetry): #59 🔒
@cmp0xff
feat(comment): #61 reuse the class HarmonicOscillatorSystem to suppor…
87d8d3a 
…t complex cases (#62)

* feat(comment): #61 #58 (comment)

* feat: #59 improve exception messages

* chore(typo): #61
@cmp0xff
feat(comment): #36 #58 (comment)
bc73c33
@cmp0xff
chore(typing): #36
ead678b
@cmp0xff cmp0xff marked this pull request as draft July 24, 2024 19:07
@cmp0xff cmp0xff changed the base branch from main to feature/cmp0xff/71-add-a-tutorial-for-the-complex-oscillator July 28, 2024 07:37
@cmp0xff cmp0xff changed the title feat: #36 one dimensional harmonic oscillator chain feat(model): #36 one dimensional harmonic oscillator chain Jul 28, 2024
@cmp0xff cmp0xff marked this pull request as ready for review July 28, 2024 09:05
Base automatically changed from feature/cmp0xff/71-add-a-tutorial-for-the-complex-oscillator to main July 29, 2024 20:16
emptymalei
emptymalei reviewed Jul 30, 2024
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
@emptymalei
Copy link
Member

emptymalei commented Jul 30, 2024 •
edited
Loading

So, I ran the tutorial, looks reasonable from an intuition perspective. I played with different initial conditions and they all seem to make sense. Also periodic condition is respected. I guess this means it is a go?

@cmp0xff cmp0xff mentioned this pull request Jul 31, 2024
Open
@cmp0xff cmp0xff merged commit baf2779 into main Aug 4, 2024
8 checks passed
@cmp0xff cmp0xff deleted the feature/cmp0xff/36-one-dimensional-circle-of-interacting-harmonic-oscillators branch August 4, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrumpySapiens GrumpySapiens GrumpySapiens left review comments

@emptymalei emptymalei emptymalei approved these changes

Assignees

@cmp0xff cmp0xff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One-dimensional circle of interacting harmonic oscillators
3 participants
@cmp0xff @emptymalei @GrumpySapiens