Fixes trueValue value evaluation on BaseSessionDriver constructor #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The constructor for
BaseSessionDriver
class evaluates the following code$isPHP7 && self::$trueValue = true && self::$falseValue = false;
tofalse
for variableself::$trueValue
.So when
Files
class calls theopen()
method, the return value for the functionself::true()
returns false, resulting on the session file and cookie not being created.Tested on
PHP 7.4.30
using theFiles
driver using version1.1-stable
Fix solution
Changing the aforementioned evaluation code to
$isPHP7 && (self::$trueValue = true) && ((self::$falseValue = false) === false);
fixes the issue.