Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes trueValue value evaluation on BaseSessionDriver constructor #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TiagoTeixeira85
Copy link

Problem Statement

The constructor for BaseSessionDriver class evaluates the following code $isPHP7 && self::$trueValue = true && self::$falseValue = false; to false for variable self::$trueValue.
So when Files class calls the open() method, the return value for the function self::true() returns false, resulting on the session file and cookie not being created.

Tested on PHP 7.4.30 using the Files driver using version 1.1-stable

Fix solution
Changing the aforementioned evaluation code to $isPHP7 && (self::$trueValue = true) && ((self::$falseValue = false) === false); fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant