This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
ci: Add test cases for CoCo image pulling without forked containerd #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuZhu6
force-pushed
the
image_pulling
branch
10 times, most recently
from
3c8c4f7 to
7e53865
Compare
There was a problem hiding this comment.
Hey @ChengyuZhu6, I know this is WIP, but I thought I'd have a look at it so far and I had a few suggestions, so I'll share them now in case they are helpful.
integration/kubernetes/confidential/image_pulling_with_snapshotter.bats
Outdated
Show resolved
Hide resolved
integration/kubernetes/confidential/image_pulling_with_snapshotter.bats
Outdated
Show resolved
Hide resolved
ChengyuZhu6
force-pushed
the
image_pulling
branch
15 times, most recently
from
cded57c to
6bcb317
Compare
ChengyuZhu6
changed the title
katacontainersbot
added
size/large
ChengyuZhu6
force-pushed
the
image_pulling
branch
3 times, most recently
from
7bdeffa to
e369086
Compare
|
/test |
ChengyuZhu6
force-pushed
the
image_pulling
branch
2 times, most recently
from
5f6a79f to
c9abba0
Compare
|
/test |
ChengyuZhu6
force-pushed
the
image_pulling
branch
2 times, most recently
from
4a2f444 to
2d29b13
Compare
|
/test |
ChengyuZhu6
force-pushed
the
image_pulling
branch
7 times, most recently
from
9627e1a to
9909440
Compare
|
/test |
ChengyuZhu6
force-pushed
the
image_pulling
branch
3 times, most recently
from
2a65eeb to
da29a1b
Compare
|
/test |
added 3 commits
September 21, 2023 10:03
Additional tests are necessary to verify new feature that pulling image without forked containerd in CoCo. 1)image sharing on the host without dm-verity. 2)image sharing on the host with dm-verity. 3)image pulling in the guest with nydus-snapshotter. Fixes kata-containers#5763 Depends-on: github.com/kata-containers/kata-containers#7676 Signed-off-by: ChengyuZhu6 <[email protected]>
Install nydus-snapshotter dependencies. Signed-off-by: ChengyuZhu6 <[email protected]>
add function to install vanilla containerd Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
image_pulling
branch
2 times, most recently
from
c56d1bb to
3121183
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional tests are necessary to verify new feature that pulling image without forked containerd in CoCo.
1)image sharing on the host without dm-verity.
2)image sharing on the host with dm-verity.
3)image pulling in the guest with nydus-snapshotter.
Fixes #5763
Depends-on:
kata-containers/kata-containers#7676