Skip to content
This repository was archived by the owner on May 20, 2024. It is now read-only.

Added Facebook link and fixed some typos. #468

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Added Facebook link and fixed some typos. #468

merged 2 commits into from
Apr 28, 2017

Conversation

PabloCarmona
Copy link
Contributor

Hello, this is my first contribution to this project I get interested in push.
I hope all goes good with my implementation.
If I make mistakes on something let me now I'm here to help and learn!

Thank you!

…or Facebook link tooltip. Fixed typo in Github link for Spanish.
@codecov-io
Copy link

codecov-io commented Apr 20, 2017

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         207      207           
  Lines        2935     2935           
=======================================
  Hits         2892     2892           
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8f67e...151efb5. Read the comment docs.

@PabloCarmona
Copy link
Contributor Author

I realized that we can put the link also in the blog page. You think is good idea?

@tiltec
Copy link
Member

tiltec commented Apr 21, 2017

Hi Pablo, great start, nice to have you here! Maybe the topbar is getting too full, what do you think about extending the footer? Otherwise it's perfect!

I guess we can have it on the blog as well - do you know how to modify our blog (based on Jekyll)?

@PabloCarmona
Copy link
Contributor Author

I can't see any footer in the page. If you want I can create one following the styling rules and for the blog I haven't any experience in work with Jekyll but I can give it a shot and inform you with the progress.

Thanks for bring me the oportunity to join this cool project!

@tiltec
Copy link
Member

tiltec commented Apr 24, 2017

True, there is no footer on the landing page and on the splash pages. But there is one when you are on the "main" view (e.g. viewing a group or a store).

(Sorry for the delay, still travelling around!)

@tiltec
Copy link
Member

tiltec commented Apr 27, 2017

More detail: the footer is here
You can simply extend it for now - later on, we should refactor it into a component to reuse it on the login page etc..

@PabloCarmona
Copy link
Contributor Author

PabloCarmona commented Apr 28, 2017

Added the link in the footer. Sorry for the delay and thanks for help! 😄
I will maintain the link the topbar also to reach the people that aren't join if you want.

@tiltec tiltec merged commit 396bdff into karrot-dev:master Apr 28, 2017
@tiltec
Copy link
Member

tiltec commented Apr 28, 2017

Merged!
Our translations are handled in transifex, I fixed the spelling here instead: https://www.transifex.com/yunity-1/foodsaving-tool/translate/#es/frontend/102480249

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants