Skip to content

Update controller-runtime to v0.21.0 and all Go runtime metrics are enabled #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dongjiang1989
Copy link
Member

What type of PR is this?

What this PR does / why we need it:
Update controller-runtime to v0.21.0 and all Go runtime metrics are enabled

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update controller-runtime to v0.21.0 and all Go runtime metrics are enabled

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2025
@RainbowMango RainbowMango added this to the v1.15 milestone May 26, 2025
@RainbowMango
Copy link
Member

The [email protected] requires Kubernetes v1.33, but Karmada now requires v1.32.
Since we are heading to the v1.14 release by the end of this month, I guess we can start bumping Kubernetes to v1.33, and then we will be ready to bump the controller runtime.
@dongjiang1989 can we wait for a while?

@dongjiang1989
Copy link
Member Author

@dongjiang1989 can we wait for a while?

Thanks @RainbowMango
Got it

@RainbowMango
Copy link
Member

Hi @dongjiang1989 As controller-runtime is relying on Kubernetes, it should be bumped along with Kubernetes.
The #6498 bumps Kuberentes as well as controller-runtime(v0.21.0), and it is almost ready to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants