Skip to content

Commit

Permalink
Merge pull request #2092 from carlory/karmadactl-exec
Browse files Browse the repository at this point in the history
use kubectl exec to implement karmadactl exec and introduce the `--namespace` flag
  • Loading branch information
karmada-bot authored Jul 11, 2022
2 parents 778b2ea + a31315c commit d2bd9d9
Show file tree
Hide file tree
Showing 11 changed files with 1,251 additions and 302 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ require (
github.com/gogo/protobuf v1.3.2
github.com/google/uuid v1.1.2
github.com/kr/pretty v0.3.0
github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6
github.com/olekukonko/tablewriter v0.0.4
github.com/onsi/ginkgo/v2 v2.1.3
github.com/onsi/gomega v1.18.1
Expand Down Expand Up @@ -102,6 +101,7 @@ require (
github.com/mitchellh/go-wordwrap v1.0.0 // indirect
github.com/mitchellh/mapstructure v1.4.3 // indirect
github.com/moby/spdystream v0.2.0 // indirect
github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
Expand Down
2 changes: 1 addition & 1 deletion pkg/karmadactl/describe.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func (o *CommandDescribeOptions) Complete(karmadaConfig KarmadaConfig, args []st
return err
}

f := getFactory(o.Cluster, clusterInfo)
f := getFactory(o.Cluster, clusterInfo, "")

o.Namespace, o.EnforceNamespace, err = f.ToRawKubeConfigLoader().Namespace()
if err != nil {
Expand Down
Loading

0 comments on commit d2bd9d9

Please sign in to comment.