Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary escapes filter where translations #1

Merged

Conversation

fsbraun
Copy link

@fsbraun fsbraun commented Jan 25, 2023

{% filter "escapejs" %} ... {% endfilter %} should only be used in situations where data is put into html attributes or js code.

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop
  • I have updated the CHANGELOG.rst
  • I have added or modified the tests when changing logic

{% filter "escapejs" %} ... {% endfilter %} only belongs to situations where data is put into html attributes or js code.
@corentinbettiol corentinbettiol merged commit ee0a6ce into kapt-labs:fix/french-translations-quotes Jan 25, 2023
@fsbraun fsbraun deleted the patch-1 branch April 5, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants